[Sketcher] projection of (implemented)

[shermelin]

Dear all,

I implemented the projection of ellipses in sktcehr, hopefully including corner cases (projects to a line or a circle).

I just submitted PR #3479.

Best,

[RatonLaveur]

That is really cool! Thanks you so much for your contribution!

[chrisb]

A true enhancement, thanks!

[shermelin]

It was a pleasure to make the calculations, I had not done any in ages…
Not son fun to debug my sleep deprived typos un close variable names…

By the way, opencascade has a projection library, which does not make the right calculations I believe. Anyone ever worked with them upstream? 'Cause it would be much cleaner to pish most of that code upstream and clean sketcher code…

[chrisb]

shermelin, you had two posts here almost identical, in the second you had just corrected a huge bunch of typos. I have removed the buggy post. I know this problem very well, because I make myself so many errors, but it is not necessary to create a second post. You can edit an existing post by using the pencil symbol at the right top of the post.

[shermelin]

Thanks Chrisb. I still had the input form, I thought I had tapped on preview by mistake… did not seem to be able to delete the older post once I had double posted…

[chrisb]

did not seem to be able to delete the older post once I had double posted…

That's indeed not possible, you can delete only the last post in a topic. (We moderators can use our super powers and delte other things as well).

[abdullah]

It was a pleasure to make the calculations, I had not done any in ages…
Not son fun to debug my sleep deprived typos un close variable names…

By the way, opencascade has a projection library, which does not make the right calculations I believe. Anyone ever worked with them upstream? 'Cause it would be much cleaner to pish most of that code upstream and clean sketcher code…

Thank you for your contribution!! The PR is now merged.

I comment that I have pushed a commit just after to fix some warnings about unused variables and a function.

I had to check that the projection of an ellipse is always an ellipse (other than when it degenerates to a circle or a segment). I remember that the offset curve of an ellipse is not an ellipse, so I double checked and I learned something in the way.

As I am kind of integrator in practice, I hope that nothing has escaped me this time...

[Kunda1]

By the way, opencascade has a projection library, which does not make the right calculations I believe. Anyone ever worked with them upstream? 'Cause it would be much cleaner to pish most of that code upstream and clean sketcher code…

We have worked with them in the past. See OCC Bugs in the Bugtracker.

There is a also an OCC dev that hangs on the forum, maybe we can ping him?

I constructed google table representing all existing OCCT issues related to the FC: https://docs.google.com/spreadsheets/d/ ... sp=sharing
Feel free to add your comments and suggestions for improvement. I will be glad to get feedback from the community.