Units in .inp file writer

[PrzemoF]

That unit handling code doesn't look right [1]

Code: Select all

        for MaterialObject in self.MaterialObjects:
            # get material properties
            YM = FreeCAD.Units.Quantity(MaterialObject['Object'].Material['Mechanical_youngsmodulus'])
            if YM.Unit.Type == '':
                print 'Material "Mechanical_youngsmodulus" has no Unit, asuming kPa!' <-- assuming kPa...
                YM = FreeCAD.Units.Quantity(YM.Value, FreeCAD.Units.Unit('Pa')) <-- but setting Pa. What's the reason?
            else:
                print 'YM unit: ', YM.Unit.Type <-- this prints "YM Unit: Pressure", not very useful
            print 'YM = ', YM  <-- this prints "YM = 2e+08 kg/mm*s^2", again the units are not useful
            PR = float(MaterialObject['Object'].Material['FEM_poissonratio'])
            print 'PR = ', PR
            # write material properties
            inpfile.write('*MATERIAL, NAME=' + MaterialObject['Object'].Material['General_name'] + '\n')
            inpfile.write('*ELASTIC \n')
            inpfile.write('{0:.3f}, '.format(YM.Value * 1E-3)) <-- this conversion by 1/000 is unit independent, so if the YM unit is not kPa it will produce something else not expected MPa
            

I want to flag that for review in case I missed something.
[1] https://github.com/FreeCAD/FreeCAD_sf_m ... is.py#L498

[bernd]

I did not change anything on that with the last commit. It's the following commit you are talking about.
https://github.com/FreeCAD/FreeCAD_sf_m ... 7db34dcd6e
(https://github.com/FreeCAD/FreeCAD_sf_m ... 400602R444)

Nothing has been changed on youngs modulus since then. That was done at a time when lot of things were messed up in FEM to get some system running. Setting unit to Pa is from years ago.

[PrzemoF]

OK, makes perfect sense. We'll clean it later, after splitting the .inp write code.

[bernd]

We'll clean it later, after splitting the .inp write code.

+1