FEM Python coding standard

[vanuan]

the document I referenced only has coding standards which are fulfilled by FEM python code already.

How do you enforce it? What if one day you discover FEM doesn't fulfill it anymore? Do you catch all the issues during review? What if you miss an issue? What if you need to change the code which is not a part of FEM? Aren't you annoyed it doesn't fulfill the coding style you've used to?

AFAIK FEM and Draft uses flake8. Only difference is the indent. Draft uses other indent style as FEM.

As far as I can see, flake8 is disabled:
https://github.com/FreeCAD/FreeCAD/blob ... #L124-L130

Do you mean you run it yourself each time you do a pull? How is it being run and when?

[bernd]

all checks are done by myself. I use flake8 for this. The command I usd is in the code convention file.

Usually all FEM python code is reviewed by me before merge. If there are only a few changes needed I merge and do them manually. Werner himself does not really follow pep8 strictly. Normally I do change this afterwards. I do only change coding style in FEM. In other workbenches I would get in touch with the maintainer first. Most dev which do code in FEM makes flake8 themself. I just ask them very kindly to do this again and again. Most of them have adopted this.

[bernd]

I am known commit history and code formating freak! IMHO it helps very much to understand code. May be I like this because I am a poor dev