[Merged] PR #2389 - Thickness tools is missing intersection-toggle option

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
rynn
Posts: 111
Joined: Tue Jul 31, 2018 7:00 am

[Merged] PR #2389 - Thickness tools is missing intersection-toggle option

Post by rynn » Wed Jul 24, 2019 2:15 pm

The thickness-tool from part has a intersection-toggle-option (not the join type) that, in same cases, is necessary to p.e. apply an inward thickness (Part: negativ thickness, Part-design: Reversed == true").
This option is missing from the part-design thickness-tool.

Code: Select all

OS: Ubuntu 16.04.6 LTS (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.17469 (Git)
Build type: Release
Branch: master
Hash: 96b74022e3681c9e5bde88ea72ae9c412e25ed20
Python version: 2.7.12
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)
Attachments
Thickness-example.FCStd
(34.98 KiB) Downloaded 27 times
Last edited by Kunda1 on Tue Aug 27, 2019 10:59 pm, edited 1 time in total.
openBrain
Posts: 3089
Joined: Fri Nov 09, 2018 5:38 pm

Re: Thickness tools is missing intersection-toogle

Post by openBrain » Wed Jul 24, 2019 3:00 pm

What are proposing then ? Some code or PR ?
If the purpose of your post is to get help or confirm it's a bug & deserves a ticket, it should be located in the Help subforum. ;)
rynn
Posts: 111
Joined: Tue Jul 31, 2018 7:00 am

Re: Thickness tools is missing intersection-toogle

Post by rynn » Wed Jul 24, 2019 3:27 pm

openBrain wrote:
Wed Jul 24, 2019 3:00 pm
What are proposing then ? Some code or PR ?
If the purpose of your post is to get help or confirm it's a bug & deserves a ticket, it should be located in the Help subforum. ;)
I don’t think it’s a bug, more of a missing feature.

In my case this is easy to fix: simply set the intersection parameter in the Part::TopoShape::makeThickSolid call to true.
But I’m not sure what this means for other uses, as I do not understand the parameters at all.
patch.txt
Patch: set intersect == true
(733 Bytes) Downloaded 30 times
rynn
Posts: 111
Joined: Tue Jul 31, 2018 7:00 am

Re: Thickness tools is missing intersection-toogle

Post by rynn » Thu Jul 25, 2019 11:52 am

Hi,

I added a Intersection-option to toggle the intersection flag.
Patch appended.
Attachments
Thickness.patch.txt
(6.59 KiB) Downloaded 32 times
openBrain
Posts: 3089
Joined: Fri Nov 09, 2018 5:38 pm

Re: Thickness tools is missing intersection-toogle

Post by openBrain » Thu Jul 25, 2019 12:20 pm

Great. Would it be possible that you submit a PR in GitHub rather than a unified diff here ?
Note that before doing so, you have to :
  • Basically ensure that your code is working and doesn't introduce regressions
  • Rebase against the latest master
  • Locally run the test set
rynn
Posts: 111
Joined: Tue Jul 31, 2018 7:00 am

Re: Thickness tools is missing intersection-toogle

Post by rynn » Wed Jul 31, 2019 11:19 am

Added a PR: https://github.com/FreeCAD/FreeCAD/pull/2389

TestPartDesignApp and TestPartDesignGui are passing here.
openBrain
Posts: 3089
Joined: Fri Nov 09, 2018 5:38 pm

Re: Thickness tools is missing intersection-toogle

Post by openBrain » Wed Jul 31, 2019 12:15 pm

:+1:
freecad-heini-1
Posts: 6436
Joined: Tue Jan 07, 2014 11:10 am
Contact:

Re: Thickness tools is missing intersection-toogle

Post by freecad-heini-1 » Wed Jul 31, 2019 4:18 pm

rynn wrote:
Wed Jul 31, 2019 11:19 am
Added a PR: https://github.com/FreeCAD/FreeCAD/pull/2389

TestPartDesignApp and TestPartDesignGui are passing here.
Unfortunately I don't know how to add improvements to Freecad. My question about this improvement. Until when will it be included in the daily Builds versions? What about the Thickness Tool of the Part-Workbench? Will this be improved at the same time, or is this a separate process? Is there a benchmark test or something similar to test if the tool can hollow out parts that didn't work before? I'm looking forward to answers.
Many greetings
Wilfried

Translated with www.DeepL.com/Translator
rynn
Posts: 111
Joined: Tue Jul 31, 2018 7:00 am

Re: Thickness tools is missing intersection-toogle

Post by rynn » Wed Jul 31, 2019 7:23 pm

freecad-heini-1 wrote:
Wed Jul 31, 2019 4:18 pm
What about the Thickness Tool of the Part-Workbench? Will this be improved at the same time, or is this a separate process?
This feature already is in the Part-workbench Thickness tool. It was missing in PartDesign only.
There is another toggle in the Part Thickness tool (Self-intersection), that I don’t understand.
rynn
Posts: 111
Joined: Tue Jul 31, 2018 7:00 am

Re: Thickness tools is missing intersection-toogle

Post by rynn » Fri Aug 23, 2019 6:34 am

rynn wrote:
Wed Jul 31, 2019 11:19 am
Added a PR: https://github.com/FreeCAD/FreeCAD/pull/2389
Is there some additional procedure one has to do, to get a pull-request pulled?
Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest