No. Just wait a developer can review the code and merge it if OK. If not you'll get done remarks.
[Merged] PR #2389 - Thickness tools is missing intersection-toggle option
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Thickness tools is missing intersection-toogle
Thanks for the PR. Core devs are pretty backed up with bug fixes for the previous Link branch merge + Packaging / Dependencies and CI fixes. They'll get around to this.
JFYI, please familiarize yourself with the difference between git merge and git rebase (rebase is more appropriate because it doesn't pollute the commit history). Also it helps when you label your commits in a sequential way so that the devs can follow the logic of how you coded things. Just some things to keep in mind for the future. Cheers!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: Thickness tools is missing intersection-toogle
If you refere to the list of“Merge branch 'master' into feature/thickness-intersect”-mergesKunda1 wrote: ↑Tue Aug 27, 2019 11:03 pm JFYI, please familiarize yourself with the difference between git merge and git rebase (rebase is more appropriate because it doesn't pollute the commit history). Also it helps when you label your commits in a sequential way so that the devs can follow the logic of how you coded things. Just some things to keep in mind for the future. Cheers!
These are the result of the [update branch]-button in github. So do not use this?
Re: PR #2389 - Thickness tools is missing intersection-toggle option
Not an expert but AFAIK, the way to go is to rebase locally then pushing :
Code: Select all
git pull --rebase upstream/master
git push [origin/my_branch]