Hole dialog discussion

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
ToniTen
Posts: 60
Joined: Fri Sep 04, 2020 10:11 am

Re: Hole dialog discussion

Post by ToniTen » Fri Nov 13, 2020 1:52 pm

Are the names for the Hole Cut translatable? Counterbore and countersink don't mean much in languages other than English. If they are translatable, I propose the following translations for Spanish (Spain):

counterbore = refrentado
countersink = avellanado

sorry, forgot to add the FreeCAD version information

Code: Select all

OS: Ubuntu 18.04.5 LTS (XFCE/xubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.22960 (Git) AppImage
Build type: Release
Branch: master
Hash: c5a4b01d2e4218bcc0eb6650337650a6c65ef0e4
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: Spanish/Spain (es_ES)
chrisb
Posts: 30620
Joined: Tue Mar 17, 2015 9:14 am

Re: Hole dialog discussion

Post by chrisb » Fri Nov 13, 2020 3:54 pm

These translations are done via Crowdin.
You need at least FreeCAD 0.19.23300 to edit my current sketches.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
rynn
Posts: 226
Joined: Tue Jul 31, 2018 7:00 am

Re: Hole dialog discussion

Post by rynn » Fri Nov 13, 2020 4:11 pm

chrisb wrote:
Fri Nov 13, 2020 3:54 pm
These translations are done via Crowdin.
These names are read on runtime from files. I don’t know enough about the freecad Enumeration classes, that are used here, to give a based opinion, but I doubt translation is possible here without major changes in the code.
wmayer
Site Admin
Posts: 16849
Joined: Thu Feb 19, 2009 10:32 am

Re: Hole dialog discussion

Post by wmayer » Fri Nov 13, 2020 4:53 pm

With git commit b7d763a1c they can be translated now.
GeneFC
Posts: 1785
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: Hole dialog discussion

Post by GeneFC » Fri Nov 13, 2020 8:19 pm

Might be fun to see how "Cheesehead" is translated into various languages. :lol:

Gene
User avatar
uwestoehr
Posts: 2144
Joined: Sun Jan 27, 2019 3:21 am

Re: Hole dialog discussion

Post by uwestoehr » Sat Nov 14, 2020 2:20 am

The hole dialog is a beast - so many possible combinations when changing settings.

While testing I found several issues according to the countersink angle.

This PR fixes them: https://github.com/FreeCAD/FreeCAD/pull/4050

I had a look at the norms, and they only define screw heads, not how the holes for a countersink/bore must look. So you are not only free to cut with a larger or smaller diameter but also with a custom sink angle.
uwestoehr wrote:
Fri Nov 13, 2020 12:50 am
when changing the depth for a countersink, nothing happens.
This is fixed as well with this PR.

--------------------

Today I realized that the hole feature does not provide cuts for screws according to the norm ISO 8677. So the dialog should in future support also square cuts.
UR_
Posts: 1212
Joined: Tue Jan 03, 2017 8:42 pm

Re: Hole dialog discussion

Post by UR_ » Sat Nov 14, 2020 3:44 am

uwestoehr wrote:
Sat Nov 14, 2020 2:20 am
I had a look at the norms, and they only define screw heads, not how the holes for a countersink/bore must look.
Please have a look at "DIN 74 countersinks for countersunk head screws" and including DIN ISO 20273.
rynn
Posts: 226
Joined: Tue Jul 31, 2018 7:00 am

Re: Hole dialog discussion

Post by rynn » Sat Nov 14, 2020 11:04 am

UR_ wrote:
Sat Nov 14, 2020 3:44 am
uwestoehr wrote:
Sat Nov 14, 2020 2:20 am
I had a look at the norms, and they only define screw heads, not how the holes for a countersink/bore must look.
Please have a look at "DIN 74 countersinks for countersunk head screws" and including DIN ISO 20273.
The problem is, these cost a fortune: DIN 74 (42,88 €) and DIN EN 20273 (30,23 €)
That’s why most developers here do not have access.
User avatar
uwestoehr
Posts: 2144
Joined: Sun Jan 27, 2019 3:21 am

Re: Hole dialog discussion

Post by uwestoehr » Sat Nov 14, 2020 12:08 pm

UR_ wrote:
Sat Nov 14, 2020 3:44 am
Please have a look at "DIN 74 countersinks for countersunk head screws" and including DIN ISO 20273.
This defines hole diameter sizes:
https://cad-markt.de/index.php/cad-tutu ... bmessungen
or
http://www.iim.maschinenbau.tu-darmstad ... 20273.html

So we have 2 issues:
- some of our "close fit" diameters for metric holes are incorrect (we use e.g. values like 3.15 despite the norms define a precision of max 0.1 mm)
- we don't support the defined "coarse fit"

I'll correct/add this after the pending PR is merged.
chrisb
Posts: 30620
Joined: Tue Mar 17, 2015 9:14 am

Re: Hole dialog discussion

Post by chrisb » Sat Nov 14, 2020 12:14 pm

I asked Yorik if this can be payed from the FreeCAD account.
You need at least FreeCAD 0.19.23300 to edit my current sketches.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest