Arch Building Part still touched after recompute

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

- load the file
- in TreeVies select object "myLayer1"
- in PropertyEditor --> Tab Data --> Group --> Value --> click on the three dots
- Add Column1 and Column2
- They will be grey, the original colors get lost.

To be honest, I am not sure if it is Arch or Link bug.
Attachments
view-problem_03_layer.FCStd
(30.85 KiB) Downloaded 61 times
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

BTW it exist on FreeCAD head ond on your GroupMod branch.
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: Arch Building Part still touched after recompute

Post by realthunder »

bernd wrote: Mon Nov 25, 2019 3:31 pm To be honest, I am not sure if it is Arch or Link bug.
I think that is a designed behavior. The color change code is at DraftLayer.py:194. The behavior is that if Layer.ViewObject.OverrideChildren is True (which is default, I think), then it will override the children color with its own.

BTW, here is a trick to find out which python code changes which property.

Code: Select all

App.setLogLevel('Property',4)
Then go to ReportView to see the trace message. You need to enable ReportView Logging (with its context menu) to see the trace. To silent the trace, set the log level back to 2 or above.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

realthunder wrote: Tue Nov 26, 2019 12:23 am I think that is a designed behavior.
Got it. Yes it is designed behavior. To deactivate it one must set "Override Children" to False in Layers ViewProvider.

OK colors are fine, but still there are some problems ... I will post later on ...
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

- load the file
- change the visibility of the layer objects --> it will change the visibility of the objects :)
- set visibility of the buildings to True (myBuilding1 and myBuilding2)
- again change the visibility of the layer objects --> it will NOT change the visibility of the objects :(

view-problem_04_layer.FCStd
(30.92 KiB) Downloaded 72 times

EDIT: problems only in master noch in GroupMod branch
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

the layers work great with your branch https://github.com/realthunder/FreeCAD/tree/GroupMod :D
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

when will there be a PR for the GroupMod branch?
vocx
Veteran
Posts: 5197
Joined: Thu Oct 18, 2018 9:18 pm

Re: Arch Building Part still touched after recompute

Post by vocx »

bernd wrote: Wed Nov 27, 2019 6:43 pm when will there be a PR for the GroupMod branch?
https://github.com/FreeCAD/FreeCAD/pull/2723

It's been sitting on the queue for 10 days. But Werner has a lot of work, and no computer, so merging has been slow.
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

More App Link problems ...

If the two columns in the file attached are moved (Draft move) they seam to be copied? Is it a bug or a feature?



OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.19181 (Git)
Build type: Release
Branch: master
Hash: 2504247d65271b937dd5f033a0efff9c0d7bf375
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Switzerland (de_CH)


applink-problem-move.FCStd
(14.73 KiB) Downloaded 63 times

screen.png
screen.png (140.83 KiB) Viewed 1628 times
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Arch Building Part still touched after recompute

Post by bernd »

realthunder wrote: ping
Post Reply