[merged] Draft Statusbar

[carlopav]

Thanks @carlopav! I think it's perfect way to go. I can merge 3227 already but it has merge conflicts.. Can you have a look?
About the interface, this looks good to me... We can still think of something better later on if more tools need to go to the status bar.

Ok! Wait that for me to finish the preferences tab and we can rebase and merge.

[vocx]

Thanks @carlopav! I think it's perfect way to go. I can merge 3227 already but it has merge conflicts...

I don't want to ruin the fun, but could we postpone #3227 until after #3082?

I'm not against the status bar, it's just that #3082 has many small changes all over the the new draft modules like gui_snaps and gui_snapper. These are mostly PEP8 changes, some movement of the order of the imports, and addition of docstrings. Adding Carlo's branch at this moment will cause a ton of conflicts that will take a while to correct.

These are some relevant commits in #3082. Carlo, if you can manually integrate these changes then rebasing is going to be much easier. Of course, some of the cleanup work no longer applies to Carlo's branch because of the new code.

gui_snapper
https://github.com/FreeCAD/FreeCAD/pull ... 03bbf373e1
https://github.com/FreeCAD/FreeCAD/pull ... c1f7750be0
https://github.com/FreeCAD/FreeCAD/pull ... 215866f672

gui_snaps
https://github.com/FreeCAD/FreeCAD/pull ... 97d741cc66

An alternative would be to remove these commits from #3082, and place them inside another branch, so that there are no major conflicts. Then later on they could be merged in a separate commit.

[carlopav]

I don't want to ruin the fun, but could we postpone #3227 until after #3082?

No problem to me!

[carlopav]

Here is the proposed modification of Draft Preferences.
By the way, do I have to do something to add a new panel in Draft user preferences?

pref1.JPG (76.01 KiB) Viewed 1035 times

pref2.JPG (51.1 KiB) Viewed 1035 times

[vocx]

By the way, do I have to do something to add a new panel in Draft user preferences?

Check the InitGui.py

Code: Select all

                FreeCADGui.addPreferencePage(":/ui/preferences-draft.ui", QT_TRANSLATE_NOOP("Draft", "Draft"))
                FreeCADGui.addPreferencePage(":/ui/preferences-draftsnap.ui", QT_TRANSLATE_NOOP("Draft", "Draft"))
                FreeCADGui.addPreferencePage(":/ui/preferences-draftvisual.ui", QT_TRANSLATE_NOOP("Draft", "Draft"))
                FreeCADGui.addPreferencePage(":/ui/preferences-drafttexts.ui", QT_TRANSLATE_NOOP("Draft", "Draft"))

[HakanSeven12]

What is the status of this?

[carlopav]

What is the status of this?

Hi, the PR was pending because of the massive reorganization of the Draft code vocx is carrying on.
Last conflicting commits of him were merged day before yesterday, so I was thinking to rebase my PRs next days to let Yorik evaluate the code.

[HakanSeven12]

Thanks for answer

[carlopav]

ping

PR 3228 was merged right now! thanks to everyone for the effort

[HakanSeven12]

Thanks everyone is it default or need to activate from preferences?