Sketcher task dialog

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
User avatar
uwestoehr
Posts: 1425
Joined: Sun Jan 27, 2019 3:21 am

Sketcher task dialog

Post by uwestoehr » Tue Jul 23, 2019 11:06 pm

While working with the sketcher it is somewhat annoying that one has to scroll so much because this list consumes so much space, despite it contains in almost all cases only 3 entries:
FreeCAD_tVmWN86QZN.png
FreeCAD_tVmWN86QZN.png (14.43 KiB) Viewed 898 times

There is no need to reserve space since the list will automatically be extended in size to contain its contents. This PR should do it: https://github.com/FreeCAD/FreeCAD/pull/2372

Note, I am not yet able to compile FC by myself (will be my next project), so please check if the size policy I set has the desired effect (its vertical size will be as large as necessary to contain the 3 entries, (if there are 3 entries).
chrisb
Posts: 24211
Joined: Tue Mar 17, 2015 9:14 am

Re: Sketcher task dialog

Post by chrisb » Wed Jul 24, 2019 12:17 am

Good improvement, space is always tight.
User avatar
sgrogan
Posts: 5800
Joined: Wed Oct 22, 2014 5:02 pm

Re: Sketcher task dialog

Post by sgrogan » Tue Jul 30, 2019 9:17 pm

uwestoehr wrote:
Tue Jul 23, 2019 11:06 pm
Note, I am not yet able to compile FC by myself (will be my next project), so please check if the size policy I set has the desired effect (its vertical size will be as large as necessary to contain the 3 entries, (if there are 3 entries).
I cleaned the Sketcher and SketcherGui projects and built.
Capture.PNG
Capture.PNG (13.36 KiB) Viewed 753 times
OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.17465 +1 (Git)
Build type: Release
Branch: sketcher-size-adjustments
Hash: 26176fe06b250e67fc82043443c876c8093cc414
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)
User avatar
uwestoehr
Posts: 1425
Joined: Sun Jan 27, 2019 3:21 am

Re: Sketcher task dialog

Post by uwestoehr » Tue Jul 30, 2019 9:21 pm

sgrogan wrote:
Tue Jul 30, 2019 9:17 pm
I cleaned the Sketcher and SketcherGui projects and built.
Capture.PNG
You mean with my patch applied? The aim of my patch was to reduce the whitespace since, as you can see there are only 3 entries in the list, thus the list should be as large as necessary to contain all its entries.
User avatar
sgrogan
Posts: 5800
Joined: Wed Oct 22, 2014 5:02 pm

Re: Sketcher task dialog

Post by sgrogan » Tue Jul 30, 2019 9:25 pm

uwestoehr wrote:
Tue Jul 30, 2019 9:21 pm
You mean with my patch applied? The aim of my patch was to reduce the whitespace since, as you can see there are only 3 entries in the list, thus the list should be as large as necessary to contain all its entries.
Yes, notice the branch in the About FreeCAD, the version also indicates when you applied the fix.
I added your fork as a remote, fetched the remote, and checked out your branch.

EDIT: Verified that your code changes are in the source.
Last edited by sgrogan on Tue Jul 30, 2019 9:29 pm, edited 1 time in total.
User avatar
uwestoehr
Posts: 1425
Joined: Sun Jan 27, 2019 3:21 am

Re: Sketcher task dialog

Post by uwestoehr » Tue Jul 30, 2019 9:29 pm

sgrogan wrote:
Tue Jul 30, 2019 9:25 pm
Yes, notice the branch in the About FreeCAD, the version also indicates when you applied the fix.
I added your fork as a remote, fetched the remote, and checked out your branch.
Many thanks for testing. So it is time that I am able to compile FC myself and correct the patch.

Is there any good start for me how to compile FC under Windows? (I have already Qt 5.9.x and MSVC 2015 installed)
User avatar
sgrogan
Posts: 5800
Joined: Wed Oct 22, 2014 5:02 pm

Re: Sketcher task dialog

Post by sgrogan » Tue Jul 30, 2019 9:37 pm

uwestoehr wrote:
Tue Jul 30, 2019 9:29 pm
Is there any good start for me how to compile FC under Windows? (I have already Qt 5.9.x and MSVC 2015 installed)
I think it's easiest to use the new Libpack https://forum.freecadweb.org/viewtopic. ... 89#p302601
or better yet the 12.1.3 version here: https://github.com/FreeCAD/FreeCAD/rele ... g/0.19_pre
VS2015 will be fine.
We have been working on the process as part of GSoC. If you can open a new topic in Install/Compile. I would be VERY intersested in your experience. The documentation is lacking and part of the GSoC and your insight would be valuable.
zach wrote:
Sun Jul 21, 2019 4:07 pm
ping
User avatar
uwestoehr
Posts: 1425
Joined: Sun Jan 27, 2019 3:21 am

Re: Sketcher task dialog

Post by uwestoehr » Tue Jul 30, 2019 9:42 pm

sgrogan wrote:
Tue Jul 30, 2019 9:37 pm
or better yet the 12.1.3 version here: https://github.com/FreeCAD/FreeCAD/rele ... g/0.19_pre
We have been working on the process as part of GSoC. If you can open a new topic in Install/Compile. I would be VERY intersested in your experience. The documentation is lacking and part of the GSoC and your insight would be valuable.
Many thanks. I grabbed the libpack now and will try to compile the next days. I will report back as soon as I found time for testing.
Too bad that there is no step-by-step instruction yet but when I succeed, I will write one in the Wiki.
User avatar
sgrogan
Posts: 5800
Joined: Wed Oct 22, 2014 5:02 pm

Re: Sketcher task dialog

Post by sgrogan » Tue Jul 30, 2019 9:44 pm

uwestoehr wrote:
Tue Jul 30, 2019 9:42 pm
Many thanks. I grabbed the libpack now and will try to compile the next days. I will report back as soon as I found time for testing.
Too bad that there is no step-by-step instruction yet but when I succeed, I will write one in the Wiki.
Please post on the forum this is one of @zach's tasks.
User avatar
zach
Posts: 29
Joined: Thu Apr 04, 2019 4:56 pm
Location: Texas

Re: Sketcher task dialog

Post by zach » Tue Jul 30, 2019 9:45 pm

I should have the write up complete soon. :D
GSoC FreeCAD Blog: zachgummow.github.io
Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest