Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

pablogil
Posts: 800
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by pablogil » Wed Feb 15, 2017 10:20 pm

Kunda1 wrote:Should this thread be moved to the UI/UX Design subforum ?
I guess so...
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
galou_breizh
Posts: 290
Joined: Wed Sep 15, 2010 9:38 am

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by galou_breizh » Mon Jan 13, 2020 12:57 pm

I'm sorry if this was already mentioned before but I don't really have the time to read this long forum topic.

I have an issue with the darker-blue theme, where I have difficulties to distinguish selected (very-light gray on blue background) from unselected text (white on blue background) in the formula editor. Interestingly when I tried to make a screenshot with `scrot`, the difference was clear (unselected=white on dark-gray background vs. selected=blue background). For this reason, the screenshot was done with my phone.
eq_editor.jpg
eq_editor.jpg (88.04 KiB) Viewed 306 times
Hint: the selected text is
<<Dims>>.wall_thickness
Does someone face the same issue?

Thanks,
Gaël

OS: Ubuntu 18.04.3 LTS (i3/i3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.6.9
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
pablogil
Posts: 800
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by pablogil » Mon Jan 13, 2020 1:50 pm

galou_breizh wrote:
Mon Jan 13, 2020 12:57 pm
I'm sorry if this was already mentioned before but I don't really have the time to read this long forum topic.

I have an issue with the darker-blue theme, where I have difficulties to distinguish selected (very-light gray on blue background) from unselected text (white on blue background) in the formula editor. Interestingly when I tried to make a screenshot with `scrot`, the difference was clear (unselected=white on dark-gray background vs. selected=blue background). For this reason, the screenshot was done with my phone.

eq_editor.jpg

Hint: the selected text is
<<Dims>>.wall_thickness
Does someone face the same issue?

Thanks,
Gaël

OS: Ubuntu 18.04.3 LTS (i3/i3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.6.9
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
Hi,

I can reproduce it, thanks for the comment.
I will try to solve it as soon as I can, thanks.

Cheers
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
pablogil
Posts: 800
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by pablogil » Tue Jan 14, 2020 7:48 am

Hi,

I have just submitted a pull request solving the issue. ;)
You can test it here.

Cheers
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
catman
Posts: 135
Joined: Fri Jan 11, 2019 10:42 pm

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by catman » Mon Jan 20, 2020 8:48 pm

Is anyone aware of that issue with the TabBar extension (I am not sure if its a Tabbar Item or a style sheet item)?

With any selection of a style sheet in Preferences/General/StyleSheet except "no style sheet" I get those overly large TabBar buttons in the second picture. Normally they look as in the first picture.
I did not find a settings in the TabBar preferences that would correct that.
V0.19_TabBarOK.png
V0.19_TabBarOK.png (27.73 KiB) Viewed 203 times
V0.19_TabBarNOK.png
V0.19_TabBarNOK.png (27.97 KiB) Viewed 203 times
OS: Ubuntu 18.04.3 LTS (XFCE/xubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.19323 (Git) AppImage
Build type: Release
Branch: master
Hash: 1b198453b8eb6aa2eaca4e4be4b49fee74e9de6e
Python version: 3.8.1
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)
pablogil
Posts: 800
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by pablogil » Mon Jan 20, 2020 9:37 pm

catman wrote:
Mon Jan 20, 2020 8:48 pm
Is anyone aware of that issue with the TabBar extension (I am not sure if its a Tabbar Item or a style sheet item)?

With any selection of a style sheet in Preferences/General/StyleSheet except "no style sheet" I get those overly large TabBar buttons in the second picture. Normally they look as in the first picture.
I did not find a settings in the TabBar preferences that would correct that.

V0.19_TabBarOK.png V0.19_TabBarNOK.png

OS: Ubuntu 18.04.3 LTS (XFCE/xubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.19323 (Git) AppImage
Build type: Release
Branch: master
Hash: 1b198453b8eb6aa2eaca4e4be4b49fee74e9de6e
Python version: 3.8.1
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)
It seems to be related with stylesheets, yes. Anyway, TabBar is not fully supported by the official stylesheets. Only "Selector Toolbar" is supported and fully functional so I would suggest you to use this one instead.

Let me know if this solves the issue ;)

Cheers
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
catman
Posts: 135
Joined: Fri Jan 11, 2019 10:42 pm

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by catman » Mon Jan 20, 2020 10:04 pm

pablogil wrote:
Mon Jan 20, 2020 9:37 pm
It seems to be related with stylesheets, yes. Anyway, TabBar is not fully supported by the official stylesheets. Only "Selector Toolbar" is supported and fully functional so I would suggest you to use this one instead.
They are very similar indeed. ;)
Unfortunately the effect is still there. Its different but not fully ok yet. Here is an updated image.

V0.19_TabBarAndSelectorBar_NOK.jpg
V0.19_TabBarAndSelectorBar_NOK.jpg (26.99 KiB) Viewed 185 times
.

* TabBar is Horizontal. The Selector bar has even a bit wider buttons when put horizontal.
* SelectorBar is vertical. The vertical spacing is OK, but horizontally its too wide. The TabBar was horizontal OK, but vertical NOK.
* Both bars are fine with No Style Sheet
pablogil
Posts: 800
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by pablogil » Mon Jan 20, 2020 10:38 pm

Umm,

OK, I have tested them both and I found the issue, let me know if this attached stylesheet solves the problem and I PR to master.

Just in case you don't know how to install it, place the .qss file in the path that fits your OS:
  • OSX = /Users/[YOUR_USER_NAME]/Library/Preferences/FreeCAD/Gui/Stylesheets/
  • WINDOWS = C:/[INSTALLATION_PATH]/FreeCAD/data/Gui/Stylesheets/
  • LINUX = /home/[YOUR_USER_NAME]/.FreeCAD/Gui/Stylesheets/
Thanks
Attachments
Dark-blue-222.zip
(10.27 KiB) Downloaded 6 times
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
catman
Posts: 135
Joined: Fri Jan 11, 2019 10:42 pm

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by catman » Tue Jan 21, 2020 1:12 am

pablogil wrote:
Mon Jan 20, 2020 10:38 pm
OK, I have tested them both and I found the issue, let me know if this attached stylesheet solves the problem and I PR to master.

Just in case you don't know how to install it, place the .qss file in the path that fits your OS:

OSX = /Users/[YOUR_USER_NAME]/Library/Preferences/FreeCAD/Gui/Stylesheets/
WINDOWS = C:/[INSTALLATION_PATH]/FreeCAD/data/Gui/Stylesheets/
LINUX = /home/[YOUR_USER_NAME]/.FreeCAD/Gui/Stylesheets/
Yes that worked.
The SelectorBar is fine now in both directions.
The TabBar is still not OK, but since they have the same functions, this is not a problem.

Thanks for the quick fix! :D
pablogil
Posts: 800
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: Dark and Light FreeCAD stylesheets (2.x, 3.x,...) and beyond

Post by pablogil » Tue Jan 21, 2020 7:48 am

catman wrote:
Tue Jan 21, 2020 1:12 am
Yes that worked.
The SelectorBar is fine now in both directions.
The TabBar is still not OK, but since they have the same functions, this is not a problem.

Thanks for the quick fix! :D
Great, I will update the master then.
If you find any other issue just let me know here ;)

Cheers
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests