PartDesign Body Origin

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

vocx
Posts: 3338
Joined: Thu Oct 18, 2018 9:18 pm

PartDesign Body Origin

Post by vocx » Sun Dec 08, 2019 10:40 pm

I haven't seen any discussion about this. When the LinkMerge happened, realthunder changed the icon for the PartDesign Body Origin object. I personally prefer the old icon because it shows the typical three-axes coordinate system. The new icon consists of intersecting planes, but I don't think it looks very clear, particularly when seen in isolation. My first thought when I saw the new icon was "this looks like a butterfly".

Does anybody care about this at all?

Original, CoordinateSystem.svg
PartDesign_Body_tree.png
PartDesign_Body_tree.png (18.01 KiB) Viewed 509 times
After LinkMerge, Std_CoordinateSystem.svg
PartDesign_Body_Origin.png
PartDesign_Body_Origin.png (11.26 KiB) Viewed 509 times
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
chrisb
Posts: 22455
Joined: Tue Mar 17, 2015 9:14 am

Re: PartDesign Body Origin

Post by chrisb » Sun Dec 08, 2019 11:10 pm

For me it doesn't need an icon at all. But if it should have one, I prefer the old one too.
User avatar
saso
Posts: 1418
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: PartDesign Body Origin

Post by saso » Mon Dec 09, 2019 10:00 am

+1
usbhub
Posts: 267
Joined: Tue Apr 02, 2019 8:22 pm
Location: Earth

Re: PartDesign Body Origin

Post by usbhub » Tue Dec 10, 2019 9:34 pm

+1 for the old one.
vocx
Posts: 3338
Joined: Thu Oct 18, 2018 9:18 pm

Re: PartDesign Body Origin

Post by vocx » Tue Dec 10, 2019 10:53 pm

This is just a technical note. It seems that in the code the old icon is still used for an App::Placement object, while the App::Origin object, which is used in PartDesign Body, uses the newer icon. I wonder why realthunder decided to keep both icons. Is App::Placement meant to be used by itself in a certain situation?

To know what I mean, you can run this code and see the objects in the tree view.

Code: Select all

App.ActiveDocument.addObject("App::Placement", "Placement")
App.ActiveDocument.addObject("App::Origin", "Origin")
App.ActiveDocument.addObject("PartDesign::Body", "Body")
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
vocx
Posts: 3338
Joined: Thu Oct 18, 2018 9:18 pm

Re: PartDesign Body Origin

Post by vocx » Wed Dec 11, 2019 7:16 am

vocx wrote:
Tue Dec 10, 2019 10:53 pm
It seems that in the code the old icon is still used for an App::Placement object, while the App::Origin object, which is used in PartDesign Body, uses the newer icon.
I have submitted pull request #2770 to use once more the tri-colored icon for the PartDesign Body Origin (App::Origin). Since the App::Placement object was using the same icon, I decided to create a new icon to distinguish it from the Origin.
PartDesign_old_Placement.png
After the LinkMerge, with a new Origin icon.
PartDesign_old_Placement.png (14.69 KiB) Viewed 360 times
PartDesign_new_Placement.png
After pull request #2770, with a new Placement icon.
PartDesign_new_Placement.png (14.17 KiB) Viewed 360 times
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
chrisb
Posts: 22455
Joined: Tue Mar 17, 2015 9:14 am

Re: PartDesign Body Origin

Post by chrisb » Wed Dec 11, 2019 7:30 am

What is this Placement? Is it a local coordinate system? If not, how is it created?

The new icon is not very clear to me. If it indicates some kind of placement as the name suggests, then any kind of coordinate system may be inappropriate and we may search for something completely new.
User avatar
freman
Posts: 938
Joined: Tue Nov 27, 2018 10:30 pm

Re: PartDesign Body Origin

Post by freman » Wed Dec 11, 2019 1:27 pm

Good idea to differentiate the two icons, double usage is not good.
After pull request #2770, with a new Placement icon.
PartDesign_new_Placement.png (14.17 KiB)
I think the three coloured icon is best kept for origin as this PR seems to be doing. However, I find the new icon for position rather unclear. I'm not sure that the coloured lines add any information. How about the three grey lines and the dot, without the extras? That is similar to origin but distinguishable from it.

With icons this small you can not afford to put too much in there. I don't want to have to lean forwards are peer at an icon to see what it is.

my2c.
adrianinsaval
Posts: 164
Joined: Thu Apr 05, 2018 5:15 pm

Re: PartDesign Body Origin

Post by adrianinsaval » Wed Dec 11, 2019 1:33 pm

The new icon for placemente to me looks more apropiate for the origin since it has axes and planes
vocx
Posts: 3338
Joined: Thu Oct 18, 2018 9:18 pm

Re: PartDesign Body Origin

Post by vocx » Wed Dec 11, 2019 10:09 pm

chrisb wrote:
Wed Dec 11, 2019 7:30 am
What is this Placement? Is it a local coordinate system? If not, how is it created?
As I said in the previous post you can create the object like this

Code: Select all

App.ActiveDocument.addObject("App::Placement", "Placement")
App::Placement seems to be some sort of internal object. It seems to use the App::PropertyPlacement property. Maybe it is just a test object created by Jürgen and Werner to test this property, and maybe it's not used anywhere else.

As you can see in the generated documentation diagram made by Doxygen, the PropertyPlacement is used by GeoFeature, which is the parent object of Part_Feature, which is the base object of most 2D and 3D objects in FreeCAD. So, App::PropertyPlacement is used by many objects, but the App::Placement object is not.
App_Placement.png
App_Placement.png (59.18 KiB) Viewed 288 times
The new icon is not very clear to me. If it indicates some kind of placement as the name suggests, then any kind of coordinate system may be inappropriate and we may search for something completely new.
The icon that I made for App::Placement, which I called Std_Placement.svg, is based on how this object looks in the 3D view. Of course, it can always be changed.

This is how an App::Placement looks like.
App_Placement_view.png
App_Placement_view.png (1.5 KiB) Viewed 288 times
I don't remember seeing it before. I wonder if it's used in one of the assembly workbenches, A2plus, Assembly3, Assembly4, or somewhere else.
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest