[Merged] New icons for NoShading and Hidden line

[carlopav]

This is the comparison between actual and proposed icons:

new menu.jpg (27.52 KiB) Viewed 1065 times

I'll post the svg later.

[bitacovir]

What do you think?

I think
DrawStyleFlatLines.svg
DrawStyleNoShading.svg

are too similar. Try to make them more different to each other.

DrawStyleNoShading.svg.png (11.04 KiB) Viewed 1065 times

DrawStyleFlatLines.svg.png (10.56 KiB) Viewed 1065 times

[carlopav]

are too similar. Try to make them more different to each other.

Using a gradient between the darker and the lighter color available in the palette maybe helps:

DrawStyleNoShading.svg.png (11.04 KiB) Viewed 1060 times

DrawStyleFlatLines.svg.png (14.16 KiB) Viewed 1060 times

[bitacovir]

Using a gradient between the darker and the lighter color available in the palette maybe helps:

Yes. Much better.

[carlopav]

Good, let's wait for someone else's feedback before looking for someone who can test the PR. thx!
EDIT: https://github.com/FreeCAD/FreeCAD/pull/3119

[fc_tofu]

Good, let's wait for someone else's feedback before looking for someone who can test the PR. thx!
EDIT: https://github.com/FreeCAD/FreeCAD/pull/3119

I think your news designed icons are good for identification.

As for visual style, I see 2 styles are coexisting in FreeCAD toolbars.
1. solid edge
2. hollow edge
I feel solid edge style formal and professional. Hollow edge seems cartoon flavor, and might implicate that this is a entry level software, or entertainment software.

Maybe this 2 styles have been discussed and decided before. I just don't know.

[triplus]

I left a comment on the PR, regarding the object names. And just in case if the "As Is" mode is not completely understood ATM:

https://forum.freecadweb.org/viewtopic. ... 10#p374734

[carlopav]

https://github.com/FreeCAD/FreeCAD/pull/3119
PR Updated according to triplus suggestions and ready to be merged!

[wmayer]

My favourite order and icons would be like this:

DrawStyleWireFrame.svg.png
DrawStyleHiddenLine.svg.png
DrawStyleNoShading.svg.png
DrawStyleShaded.svg.png
DrawStyleFlatLines.svg.png


I edited NoShading, Shaded and FlatLines to make them more consistent. Discarded the gradient in favour of flat face color, to emphasize the difference between the last three...
What do you think?

This looks best to me. The icons for flat lines and no shading are quite similar but IMO not a big issue. A user anyway has to test the functions in order to see how exactly they behave.

FYI, the hidden line feature is a special OpenGL trick to avoid to show lines that normally are covered by a surface. The trick is to switch off shading and to set the surface color to the background color. This leads to the visual impression that only not covered lines are displayed.

[carlopav]

Well, I'm not big fan of gradients, so i must agree with you... @bitacovir, can it be ok?
Let me know if I have to update the PR accordingly or you want to just merge it as it is now.