Very good. However, for now a simple item list does the job. E.g. for the program LyX I once wrote this simple item list:
https://www.lyx.org/trac/browser/lyxgit/INSTALL.Win32
and this is sufficient to get it compiled.
Very good. However, for now a simple item list does the job. E.g. for the program LyX I once wrote this simple item list:
These are no edit controls but solver settings. Therefore I think it is OK that they are in the separate widget for solver settings. Personally I also use the solver settings the most in the sketcher task dialog thus I am happy with the current situation that it is the topmost widget.
I just noticed that your pull request is causing Travis to fail with GCC and Python 2.uwestoehr wrote: ↑Mon Sep 23, 2019 12:25 am Since I can now compile FreeCAD. I created a better PR that solves the problem:
https://github.com/FreeCAD/FreeCAD/pull/2548
Code: Select all
In file included from /home/travis/build/FreeCAD/FreeCAD/src/Mod/Sketcher/Gui/TaskSketcherGeneral.cpp:29:0:
/home/travis/build/FreeCAD/FreeCAD/build/src/Mod/Sketcher/Gui/ui_TaskSketcherGeneral.h: In member function ‘void SketcherGui::Ui_TaskSketcherGeneral::setupUi(QWidget*)’:
/home/travis/build/FreeCAD/FreeCAD/build/src/Mod/Sketcher/Gui/ui_TaskSketcherGeneral.h:109:25: error: ‘class QListWidget’ has no member named ‘setSizeAdjustPolicy’; did you mean ‘setSizePolicy’?
renderingOrder->setSizeAdjustPolicy(QAbstractScrollArea::AdjustToContents);
^~~~~~~~~~~~~~~~~~~
setSizePolicy
/home/travis/build/FreeCAD/FreeCAD/build/src/Mod/Sketcher/Gui/ui_TaskSketcherGeneral.h:109:66: error: ‘AdjustToContents’ is not a member of ‘QAbstractScrollArea’
renderingOrder->setSizeAdjustPolicy(QAbstractScrollArea::AdjustToContents);
^~~~~~~~~~~~~~~~
src/Mod/Sketcher/Gui/CMakeFiles/SketcherGui.dir/build.make:633: recipe for target 'src/Mod/Sketcher/Gui/CMakeFiles/SketcherGui.dir/TaskSketcherGeneral.cpp.o' failed
make[2]: *** [src/Mod/Sketcher/Gui/CMakeFiles/SketcherGui.dir/TaskSketcherGeneral.cpp.o] Error 1
CMakeFiles/Makefile2:2879: recipe for target 'src/Mod/Sketcher/Gui/CMakeFiles/SketcherGui.dir/all' failed
make[1]: *** [src/Mod/Sketcher/Gui/CMakeFiles/SketcherGui.dir/all] Error 2
I am baffled because why do we insist that compatibility with Qt 4? Qt 5 was released 7 years ago (sic!) so I don't see the need to rely on such old software when a newer one is available for years. Moreover it makes it hard to work on the code since then all devs are forced to install also Qt4 to check if and how e.g. dialogs can/have to be designed.vocx wrote: ↑Wed Oct 02, 2019 3:21 pm I just noticed that your pull request is causing Travis to fail with GCC and Python 2.
See the Travis log: https://travis-ci.org/FreeCAD/FreeCAD/jobs/592368120
I am not opposed to dropping Python 2 and Qt4. With that said, it seems FreeCAD adopted Python 3 and Qt5 quite late. Only 0.18 is provided in both Py2/Qt4 and Py3/Qt5 variants. Before that, 0.17 was still Py2/Qt4 only. So, I think the rate of adoption has been quite slow.