FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
Moderator: bernd
Forum rules
and Helpful information for the FEM forum
and Helpful information for the FEM forum
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
exactly ... Try a million cells, it still works fine, but post processing and input file writing (especially for multiple materials) could take very long. All FEM in FreeCAD is not optimized on this.
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
ohh my godness ...
rebased you work on master. hopefully I did not delete anything. This is what we have so far ... https://github.com/berndhahnebach/FreeC ... aa1fdd452c on branch https://github.com/berndhahnebach/FreeC ... /femgroups
Would you just check?
cheers bernd
rebased you work on master. hopefully I did not delete anything. This is what we have so far ... https://github.com/berndhahnebach/FreeC ... aa1fdd452c on branch https://github.com/berndhahnebach/FreeC ... /femgroups
Would you just check?
cheers bernd
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
Hey bernd,
hope you're doing well in these times!
I've checked the comparisons quickly and it seems that all is there. One small thing I saw in the tests:
https://github.com/berndhahnebach/FreeC ... sh.py#L562
Shouldn't that be something like TestMeshGroups in that string?
Best wishes
Johannes
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
quite buisy at the moment, but without family on the weekend thus time for sitting all the time in front of the computer making sports having beer
git commit f90a88ce3c
good things want to have a while
How about some unit tests for the reading group methods?
git commit f90a88ce3c
good things want to have a while
How about some unit tests for the reading group methods?
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
Hehe nice one! How come that you are alone this weekend only with beer and sports and computer?
Yeah! But thanks for fast merging!
Sorry, I don't understand: What do you mean by reading group methods? But yes, once I figured out what you mean, it's definitely on my TODO list to write more tests. I would put them into the class TestMeshGroups. Is this OK for you?
I really have to catch up again in FreeCAD development. I didn't update my fork for months
Best wishes and stay safe
Johannes
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
the grandparents are happy to see their grand child and child for the first time since corona started. They are a few hundred km away.
the methods for reading group mesh data out of the mesh do not have unit tests. They could just be made similar to the once you made for editing group mesh data in the same module.
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
Ah nice! When do they come back? Right after the weekend or are they there for a whole week? I haven't seen my parents for months, too. This whole corona thing sucks!
OK, I found them: `getGroupElementType` and `getGroupElements' as well as `addGroupElements` do not have tests. What about a `removeGroupElements`? Yeah I think, that was on my agenda, but I forgot
Best wishes
Johannes
Re: FEM mesh: Create mesh groups in Python (exposing C++ functions to Python)
After solving the compiling issue, I checked the mesh groups unit tests and found out that:
- test_add_groups checks 'addGroup', 'getGroupName', 'getGroupElementType'
- test_delete_groups checks checks 'GroupCount', 'removeGroup"
- test_add_group_elements check 'addGroupElements' and 'getGroupElements'
Best wishes
Johannes