Dressup Leadin Remake

Here's the place for discussion related to CAM/CNC and the development of the Path module.
User avatar
pl7i92LCNC
Posts: 47
Joined: Tue Mar 12, 2019 3:03 pm
Location: RLP DE

Dressup Leadin Remake

Postby pl7i92LCNC » Tue Mar 12, 2019 3:52 pm

hi all im the New German tatcher replacing the Deceased Dressup maker

I refer to the 0,18 version Daily i installed on Ubuntu Bionic
The Version got the LeadinOut Dressup Repake
and this doesent work as expected while the 0,17 installed on near 100+ PC in education Here from the Dressup Builder works perfect

SO Question why has this been changed to a non Expected working version
Try the Hole CRC like in this VIDEO
https://www.youtube.com/watch?v=xOM7mg3VkUo

it works on all Systems he installed and non on the new Dressup remake
can this be changed Back so Students and users at Home can reproduce the Working G-code

Thanks for replay
User avatar
sliptonic
Posts: 1364
Joined: Tue Oct 25, 2011 10:46 pm

Re: Dressup Leadin Remake

Postby sliptonic » Wed Mar 13, 2019 3:16 am

Hi, and welcome.

I was sorry to hear about Mr Lothar passing.

Unfortunately, he was the only one maintaining the dressup and hasn't received much maintenance since. The version we had was an early implementation and he died before he was able to really stabilize the feature.

To be honest, we've had quite a bit of trouble with leadin/leadout and start points and the entire dressup needs to be rewritten. The code base has moved on in the last year so reverting isn't really an option.

Please follow this thread:
https://forum.freecadweb.org/viewtopic.php?f=15&t=34597

I really hope someone steps up to improve start points and leadin/leadout for v0.19
User avatar
pl7i92LCNC
Posts: 47
Joined: Tue Mar 12, 2019 3:03 pm
Location: RLP DE

Re: Dressup Leadin Remake

Postby pl7i92LCNC » Wed Mar 13, 2019 12:27 pm

Thank You Very Mutch for Replay
i added the Working Dressup as a Zip inside is the PY
it workes only on humen given Startpoints as YOU pointed
all the people that use it shoudt know this

BUT it woudt be better to get the "old" code online then a NEW nonworking one
Attachments
PathDressupLeadInOut.zip
Dressup Working Circle on CRC
(4.2 KiB) Downloaded 3 times
pauluzs
Posts: 27
Joined: Wed Feb 27, 2019 7:48 pm
Location: Netherlands

Re: Dressup Leadin Remake

Postby pauluzs » Wed Mar 13, 2019 6:34 pm

Just a thing i noticed:
Besides preventing errors caused between the steering-wheel and driver seat, because the amount off settings to be correct.

One of it's issues is the placement off leadout end on inside profiles should be on the same point as the leadinstart and not inside the solid
Setting a angle might be off more use than arc,tangent or perpendicular as well
Attachments
Screenshot from 2019-03-13 19-29-47.png
Screenshot from 2019-03-13 19-29-47.png (180.31 KiB) Viewed 256 times
reox
Posts: 476
Joined: Sat Aug 13, 2016 10:06 am

Re: Dressup Leadin Remake

Postby reox » Wed Mar 13, 2019 7:20 pm

I tried this yesterday too and noticed the same effect: On inside paths, the dressup will be on the outside of the path, but it looks like there is no option to control the tangent to be from the inside or from the outside.
User avatar
pl7i92LCNC
Posts: 47
Joined: Tue Mar 12, 2019 3:03 pm
Location: RLP DE

Re: Dressup Leadin Remake

Postby pl7i92LCNC » Thu Mar 14, 2019 4:40 pm

if you use this dressup from the past bevor codechange it will work
Delete the dressup change the python file and reuply the dressup
@reox
file inside the ZIP
Attachments
PathDressupLeadInOut.zip
(4.2 KiB) Downloaded 1 time
reox
Posts: 476
Joined: Sat Aug 13, 2016 10:06 am

Re: Dressup Leadin Remake

Postby reox » Thu Mar 14, 2019 7:07 pm

the changes between current master and your file are actually not too big.
Everything I see there, is that code duplication was removed by moving it into a separate function.
And even with your code, the direction is still wrong:
2019-03-14-200725_339x288_scrot.png
2019-03-14-200725_339x288_scrot.png (6.18 KiB) Viewed 179 times
Attachments
path_test.FCStd
(22.47 KiB) Downloaded 1 time
User avatar
pl7i92LCNC
Posts: 47
Joined: Tue Mar 12, 2019 3:03 pm
Location: RLP DE

Re: Dressup Leadin Remake

Postby pl7i92LCNC » Sun Mar 17, 2019 1:00 pm

if you setthe startpoint to a quadrant it will work
x27.5 y15
use startpoint True
dress.png
correct start point
dress.png (99.73 KiB) Viewed 129 times
Attachments
path_test.FCStd
(22.59 KiB) Not downloaded yet
pauluzs
Posts: 27
Joined: Wed Feb 27, 2019 7:48 pm
Location: Netherlands

Re: Dressup Leadin Remake

Postby pauluzs » Wed Mar 20, 2019 7:59 pm

Thanks for the tip,

Can do with this work around for now, only imagine a part with 100+ holes and manually setting a startpoint for each one...