Assembly4: XLink absolute filepath problem

Discussion about the development of the Assembly workbench.
aapo
Posts: 103
Joined: Mon Oct 29, 2018 6:41 pm

Re: Assembly4: XLink absolute filepath problem

Postby aapo » Fri Nov 08, 2019 8:07 am

realthunder wrote:
Fri Nov 08, 2019 12:09 am
It got stuck in one of my feature branch. I have just split it out and submitted the PR here.
After this patch will be applied, will it be possible to load old Assembly4 files containing absolute filepaths; or will there be a need to convert the files somehow?

Reading the code in the patch leads me to think, that if it's possible to read an old FCStd file, then saving the file with the patch enabed should make the xlink paths relative. Thus, I'd think that a simple load and save would make any Assembly4 files "good", but is this true?
realthunder
Posts: 1538
Joined: Tue Jan 03, 2017 10:55 am

Re: Assembly4: XLink absolute filepath problem

Postby realthunder » Fri Nov 08, 2019 11:05 pm

aapo wrote:
Fri Nov 08, 2019 8:07 am
realthunder wrote:
Fri Nov 08, 2019 12:09 am
It got stuck in one of my feature branch. I have just split it out and submitted the PR here.
After this patch will be applied, will it be possible to load old Assembly4 files containing absolute filepaths; or will there be a need to convert the files somehow?

Reading the code in the patch leads me to think, that if it's possible to read an old FCStd file, then saving the file with the patch enabed should make the xlink paths relative. Thus, I'd think that a simple load and save would make any Assembly4 files "good", but is this true?
Yes, just load and save. You may need to manually save all the linked documents, because they are not marked as changed. Just set each document as active, and save.
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
FCuser2019
Posts: 30
Joined: Fri Sep 13, 2019 12:15 pm

Re: Assembly4: XLink absolute filepath problem

Postby FCuser2019 » Mon Nov 11, 2019 8:51 pm

realthunder wrote:
Fri Nov 08, 2019 12:09 am
adrianinsaval wrote:
Thu Nov 07, 2019 9:51 pm
Sorry to bother you but are there any news on this front?
It got stuck in one of my feature branch. I have just split it out and submitted the PR here.
Thanks for this fix, FreeCAD_0.19-18714 works :)