[BUG] When inserting row in spreadsheet

[willemx]

I found a bug in the spreadsheet module: inserting an empty row introduces an error in another row below.
It is easy to reproduce, I attached a FreeCAD file with a simple spreadsheet and drawing.
to reproduce:
- open the spreadsheet and insert a new row before row 19
- you will now see an error on row 34:
09:08:29 <Spreadsheet> Cell.cpp(594): gateway#Spreadsheet.B34: Property 'doos_hi' not found in 'doos_hi'

FreeCAD version info:
OS: macOS 10.15
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.22316 (Git)
Build type: Release
Branch: master
Hash: 9beeb53a98a5f350ff185bfe0e339f38faa70512
Python version: 3.8.5
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: C/Default (C)

[Syres]

Confirmed, looks like a regression to me.

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.22319 (Git)
Build type: Release
Branch: master
Hash: 33ef4e0e35fba74c6e2fa3829cfd15c4b6f67e94
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)

[Syres]

Tested using @realthunder's PR https://github.com/FreeCAD/FreeCAD/pull/3062 and it works as expected so no need to log a bug report IMHO

OS: Linux Mint 19.3 (X-Cinnamon/cinnamon)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.21639 (Git)
Build type: Unknown
Branch: ExprCompleter
Hash: 28861791f3e664b3a4baf25682491f936f2fc30c
Python version: 3.6.9
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedKingdom (en_GB)

[chrisb]

See also: https://forum.freecadweb.org/viewtopic.php?f=3&t=50032 and issue #4429.

[wang02139]

I looked at realthunder's commit:

https://github.com/FreeCAD/FreeCAD/pull ... 10b5d5aa74

I think it hides this problem but doesn't quite fix it. The dependency graph is still wrong. revAliasProp still may have the old cell address. Sometimes, it'll read the value from the wrong cell so the result might be wrong.